Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit session types & correspond ratings to a session #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EMcNugget
Copy link
Contributor

@EMcNugget EMcNugget commented Dec 23, 2024

This PR will:

@EMcNugget EMcNugget requested a review from a team as a code owner December 23, 2024 23:15
Copy link
Collaborator

@c0repwn3r c0repwn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Could you make the edit form prefilled with the existing data?

category: form.data.category,
rating: form.data.rating
})
.where(eq(sessionTypes.id, form.data.id));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the updates aren't being triggered on my end?

Copy link
Contributor Author

@EMcNugget EMcNugget Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the updates aren't being triggered on my end?

Interesting, by not being triggered do you mean the form isn't filled with the existing data or is the db not being updated? I can't replicate either on my side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants